Feature-flag pricing tier availability for alpha vs demo/production#449
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
PricingPagecontrolled by the environment variableREACT_APP_PRICING_MODEwith modesalpha,demo, andproduction, and exposedactiveTierPolicyused throughout the page to drive behavior./api/subscription/plans) so only tiers inactiveTierPolicy.visibleare shown and only tiers inactiveTierPolicy.selectableare allowed for self-serve checkout (file:frontend/src/components/Pricing/PricingPage.tsx).frontend/src/components/Pricing/PricingPage.tsx).frontend/src/components/Pricing/PricingPage.tsx).PlanCardto acceptcanSelectPlanandunavailableLabelprops and use them to disable/label non-self-serve tiers instead of hardcoded Pro/Enterprise rules (file:frontend/src/components/Pricing/PricingPage/PlanCard.tsx).Testing
npm run buildin the container but the run failed becausereact-scriptsis not installed in this environment (error: missingfrontend/node_modules/react-scripts/scripts/build.js), so a full compile could not be validated here.npm installfollowed bynpm run buildand manual QA of the Pricing page in eachREACT_APP_PRICING_MODE(alpha,demo,production).Codex Task